Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentFinderByUrlAndTemplate uses deprecated methods and the wrong base class #18129

Open
yiangos opened this issue Jan 27, 2025 · 1 comment · May be fixed by #18137
Open

ContentFinderByUrlAndTemplate uses deprecated methods and the wrong base class #18129

yiangos opened this issue Jan 27, 2025 · 1 comment · May be fixed by #18137
Labels

Comments

@yiangos
Copy link

yiangos commented Jan 27, 2025

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0.0

Bug summary

In file Umbraco.Cms.Core.Routing.ContentFinderByUrlAndTemplate, the base class is Umbraco.Cms.Core.Routing.ContentFinderByUrl and inside, the content finder is using FileService to locate the template. This results in not finding the actual node, and the content finder is not working as advertised (i.e. /foo/bar/template does not show content from /foo/bar using template "template").

Specifics

ContentFinderByUrlAndTemplate inherits from ContentFinderByUrl. It should be inheriting from ContentFinderByUrlNew.

I don't know how to make the pull request, I have a local working copy where I've done the changes required.

Steps to reproduce

  1. Add ContentFinderByUrlAndTemplate to the list of content finders (see relevant documentation on how to do that)
  2. Make sure that Umbraco is configured to accept alternate templates (see documentation for this)
  3. Create a document type (e.g. "documentTypeTest")
  4. Add two textstring fields, "stringA" and "stringB".
  5. Create two templates (e.g. "templateA" and "templateB")
  6. In "templateA" write code to display value of "stringA".
  7. In "templateB" write code to display value of "stringB"
  8. Assign both templates to document type
  9. Set "templateA" to be default.
  10. Create a node using documentTypeTest as doctype
  11. Navigate to /path/to/node/templateB

Expected result / actual result

Expected: You should see a page with the value of stringB field.
Actual: 404 page.

Copy link

Hi there @yiangos!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@yiangos yiangos linked a pull request Jan 27, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant