fix(YaruMasterTile): let onTap override scope ontap #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the problem you're trying to solve? |
|
I think you commented 2 secs before I updated the PR desciption :P This is the use case, X tiles inside the list should not open a page but just onTap:()=> doSomething() Bildschirmaufzeichnung.vom.2023-07-27.13-41-28.webm |
|
What if we'd allow diff --git a/lib/src/widgets/master_detail/yaru_master_tile.dart b/lib/src/widgets/master_detail/yaru_master_tile.dart
index f655985..5ba8a32 100644
--- a/lib/src/widgets/master_detail/yaru_master_tile.dart
+++ b/lib/src/widgets/master_detail/yaru_master_tile.dart
@@ -76,8 +76,11 @@ class YaruMasterTile extends StatelessWidget {
trailing: trailing,
selected: isSelected,
onTap: () {
- scope?.onTap();
- onTap?.call();
+ if (onTap != null) {
+ onTap!.call();
+ } else {
+ scope?.onTap();
+ }
},
),
), |
yeah that would be even better, that was funnily what I assumed would happen when you override ontap 😄 this would also fix #718 btw |
Feichtmeier
force-pushed
the
yaru_master_tile_scope_off
branch
from
522a855 to
01799fd
Compare
Feichtmeier
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parameter to disable looking up the YaruMasterTileScope for tiles added to the list inside YMD that should not open a page.Is this the correct approach @jpnurmi ?Use case: 1 tile inside the list should open a dialog and not select/load a page
Closes #718