Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs and perform improvements #366

Closed
EresDev opened this issue Dec 30, 2024 · 7 comments · Fixed by #367
Closed

Fix some bugs and perform improvements #366

EresDev opened this issue Dec 30, 2024 · 7 comments · Fixed by #367

Comments

@EresDev
Copy link
Contributor

EresDev commented Dec 30, 2024

Some ideas that I hope will make the product more reliable, stable, easy to deploy and configure.

Improvements

  • Add a way to test cards in pull request. Currently 0$ permit will never give you a card to test in PR because no card is available at 0$.
  • reduce duplication. use non secret vars like treasury, reward token from .env vars and push them to cloudflare during deployment. Maybe even push secrets to cloudflare from github and keep all secrets in github. There should not be a need to add vars and secrets in cloudflare manually. I think this is how kernel works and this should too.
  • improve folder structure, move all configs to one /configs folder.
  • enforce yarn version in package.json (let's try this at least in this repository i think it will be helpful.)
  • add some text indicating reloadly sandbox if the page is using reloadly sandbox
  • add a way for developers to work on frontend only without worrying about or configuring much of the backend. I think this is possible by changing the base-url in frontend.
  • ask for user's name on card minting, as it is required field in Reloadly docs, but somehow it still works without name. It will be a good idea to include it. see [update] of this (Fix some bugs and perform improvements #366 (comment))
  • Do not ask user to change their rpc on metamask. Only ask user to change network if user is on the wrong network. If their rpc is down, just tell the user the rpc is down. Changing their RPC seems too invasive to me. Current code did this several times to me even though the official RPC was working fine.

Bugs

  • undefined error when wallet is connected, but not signed in. sometime it doesn't show up. more likely to show up on a new permit link.
    image
  • this is not a unknown error but a more common error. should show limited info.
    image
@EresDev
Copy link
Contributor Author

EresDev commented Dec 30, 2024

Estimated 2-3 days. I hope I have labeled time correctly.

@EresDev
Copy link
Contributor Author

EresDev commented Jan 1, 2025

/start

@0x4007 0x4007 added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jan 10, 2025
@EresDev
Copy link
Contributor Author

EresDev commented Jan 13, 2025

reduce duplication. use non secret vars like treasury, reward token from .env vars and push them to cloudflare during deployment. Maybe even push secrets to cloudflare from github and keep all secrets in github. There should not be a need to add vars and secrets in cloudflare manually. I think this is how kernel works and this should too.

I am looking into using cloudflare/wrangler-action instead of ubiquity/cloudflare-deploy-action. This helps with the above goal. ubiquity/cloudflare-deploy-action doesn't seem to help with pushing secrets from github.

@0x4007
Copy link
Member

0x4007 commented Jan 14, 2025

ask for user's name on card minting, as it is required field in Reloadly docs, but somehow it still works without name. It will be a good idea to include it.

Don't add more friction to card minting process. This should be passed in within the encoded permit from GitHub ideally

@EresDev
Copy link
Contributor Author

EresDev commented Jan 14, 2025

ask for user's name on card minting, as it is required field in Reloadly docs, but somehow it still works without name. It will be a good idea to include it.

Don't add more friction to card minting process. This should be passed in within the encoded permit from GitHub ideally

Image

After some more research, it turned out it was not user's name, but it was name of the business that mints card. That will be Ubiquity. So the cart minting process remains the same.

By the way, I have been looking into available cards for the last several days. All international cards are again unavailable at Reloadly. I thought they would add on Monday but they didn't. I asked them and they said they don't know when they cards will be available again.

@0x4007
Copy link
Member

0x4007 commented Jan 14, 2025

Seems like this will be hard to offer a reliable experience with reloadly. Maybe we should brand this feature as in beta.

Copy link
Contributor

ubiquity-os bot commented Jan 17, 2025

 [ 1408.05 UUSD ] 

@EresDev
Contributions Overview
ViewContributionCountReward
IssueTask11200
IssueSpecification1127.29
IssueComment10
ReviewComment180.76
Conversation Incentives
CommentFormattingRelevancePriorityReward
Some ideas that I hope will make the product more reliable, stab…
42.43
content:
  content:
    p:
      score: 0
      elementCount: 1
    h3:
      score: 1
      elementCount: 2
    ul:
      score: 1
      elementCount: 2
    li:
      score: 0.5
      elementCount: 10
    img:
      score: 5
      elementCount: 2
    a:
      score: 5
      elementCount: 2
  result: 29
regex:
  wordCount: 319
  wordValue: 0.1
  result: 13.43
13127.29
Estimated 2-3 days. I hope I have labeled time correctly.
0.77
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 11
  wordValue: 0.1
  result: 0.77
030
Resolves #366### QA: Preview link: https://github.com/EresDevO…
33.65
content:
  content:
    p:
      score: 0
      elementCount: 8
    h3:
      score: 1
      elementCount: 3
    a:
      score: 5
      elementCount: 2
  result: 13
regex:
  wordCount: 234
  wordValue: 0.2
  result: 20.65
0.8380.76

 [ 5.685 UUSD ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment24.893
ReviewComment10.792
Conversation Incentives
CommentFormattingRelevancePriorityReward
Don't add more friction to card minting process. This should be …
1.33
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 21
  wordValue: 0.1
  result: 1.33
0.531.995
Seems like this will be hard to offer a reliable experience with…
1.38
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 22
  wordValue: 0.1
  result: 1.38
0.732.898
I added them to the organization secrets just in case we need el…
0.88
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 13
  wordValue: 0.1
  result: 0.88
0.330.792

 [ 0.054 UUSD ] 

@rndquu
Contributions Overview
ViewContributionCountReward
ReviewComment10.054
Conversation Incentives
CommentFormattingRelevancePriorityReward
Works fine
0.18
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0.1
  result: 0.18
0.130.054

@rndquu rndquu removed this from Development Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants