Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/predefined configs #28

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Nov 22, 2024

Resolves #22
Requires #25

QA:

templates.mp4

@Keyrxng Keyrxng mentioned this pull request Nov 26, 2024
@rndquu rndquu self-requested a review November 29, 2024 16:02
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On yarn start getting the same errors as in this CI run.

Pls fix both failing build and cypress workflows.

Copy link

@Keyrxng, this task has been idle for a while. Please provide an update.

1 similar comment
Copy link

@Keyrxng, this task has been idle for a while. Please provide an update.

@ubiquity-os-beta ubiquity-os-beta bot closed this Dec 15, 2024
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Dec 20, 2024

@rndquu I can't re-open, would you mind doing it for my PRs in this repo. Sorry for the inactivity, been dealing with a bereavement.

@rndquu rndquu reopened this Dec 20, 2024
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Feb 6, 2025

This can be reviewed--I've merged in #30 so maybe after it's merged?

Right now when you select Full Default you are prompted to enter the required fields (evm private key) which is clean UI. Once the push is made, the configs are expanded and all values are visible. Is this the preferred outcome? Or should it look like this?

  1. Expanded on install let's partners see what is configurable and what everything is currently set to without deep diving all plugins.
  2. Minimized on install requires they go investigating plugins or the Custom section of the particular plugin they have in mind.

@Keyrxng Keyrxng marked this pull request as ready for review February 6, 2025 00:01
Copy link

Caution

[universal-github-app-jwt] Private Key is in PKCS#1 format, but only PKCS#8 is supported. See https://github.com/gr2m/universal-github-app-jwt#private-key-formats

@0x4007
Copy link
Member

0x4007 commented Feb 6, 2025

[!CAUTION]
[universal-github-app-jwt] Private Key is in PKCS#1 format, but only PKCS#8 is supported. See https://github.com/gr2m/universal-github-app-jwt#private-key-formats

This might be related to pull precheck based on converting the pull from draft to ready.

It also makes sense that we just now started seeing this error because it's a brand new feature.

@gentlementlegen @whilefoo rfc

@whilefoo
Copy link
Member

whilefoo commented Feb 6, 2025

This might be related to pull precheck based on converting the pull from draft to ready.

It also makes sense that we just now started seeing this error because it's a brand new feature.

@gentlementlegen @whilefoo rfc

It comes from command-start-stop and it was triggered when the PR body was edited so it seems to be the same issue as here

Copy link

Caution

[universal-github-app-jwt] Private Key is in PKCS#1 format, but only PKCS#8 is supported. See https://github.com/gr2m/universal-github-app-jwt#private-key-formats

Copy link

Caution

[universal-github-app-jwt] Private Key is in PKCS#1 format, but only PKCS#8 is supported. See https://github.com/gr2m/universal-github-app-jwt#private-key-formats

@ubiquity-os-beta ubiquity-os-beta bot closed this Feb 12, 2025
Copy link

Warning

You must be a core team member, or an administrator to start this task

Copy link

Warning

You must be a core team member, or an administrator to start this task

@gentlementlegen
Copy link
Member

@Keyrxng Sorry for the noise, this task was chosen for testing the issue with command-start-stop.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Feb 12, 2025

No worries ty for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Predefined configs
5 participants