Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commands and issue_comment.created to coexist #246

Open
gentlementlegen opened this issue Feb 14, 2025 · 2 comments
Open

Allow commands and issue_comment.created to coexist #246

gentlementlegen opened this issue Feb 14, 2025 · 2 comments

Comments

@gentlementlegen
Copy link
Member

If the manifest describes a command for a plugin, and the plugin also listens for issue_comment.created, the issue_comment.created does not get called if it doesn't match the command. This can be problematic if a plugin needs to both listen to the command and take other actions on issue_comment.created.

The current workaround is to not specify the command, and just handle handle issue_command.created. The downside is that the command will not show when invoking the /help command. This is the case for /demo for example.

Copy link

Note

The following contributors may be suitable for this task:

gentlementlegen

75% Match ubiquity-os/ubiquity-os-kernel#75

@0x4007
Copy link
Member

0x4007 commented Feb 14, 2025

A solution isn't described here. What are you planning to do? What's the trade offs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants