Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warningThreshold only used in a log #48

Closed
Keyrxng opened this issue Nov 26, 2024 · 1 comment
Closed

warningThreshold only used in a log #48

Keyrxng opened this issue Nov 26, 2024 · 1 comment

Comments

@Keyrxng
Copy link
Contributor

Keyrxng commented Nov 26, 2024

Relates to ubiquity-os/ubiquity-os-plugin-installer#24

As the title states, the config prop seems to only be used inside a log inside a similar.issue length check and the parent if block performs the same length check. So I'm struggling to understand what it's purpose is. @sshivaditya2019 any ideas?

if (similarIssues.length > 0) {
logger.info(`Similar issue which matches more than ${context.config.warningThreshold} already exists`);
await handleSimilarIssuesComment(context, payload, issueBody, issue.number, processedIssues);

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Feb 5, 2025

This was resolved here ef2add5

@Keyrxng Keyrxng closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant