Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'blacklist' verbiage to 'denylist' in cpe_chefctl #40

Open
ChefAustin opened this issue Jul 8, 2020 · 3 comments
Open

Change 'blacklist' verbiage to 'denylist' in cpe_chefctl #40

ChefAustin opened this issue Jul 8, 2020 · 3 comments
Assignees
@ChefAustin

Comments

@ChefAustin
Copy link
Contributor

We should change the use of blacklist to denylist in cpe_chefctl.

See: https://github.com/uber/cpe-chef-cookbooks/blob/876737a2ca5afd06516899d687091476bdc0fd0d/cpe_chefctl/files/default/chefctl.rb#L449
@ChefAustin ChefAustin self-assigned this Jul 8, 2020
@ChefAustin ChefAustin mentioned this issue Jul 13, 2020
Closed
@ChefAustin
Copy link
Contributor Author

Upstream issue (facebook/chef-utils#80) and PR (facebook/chef-utils#81) created and pending review/merge.

facebook-github-bot pushed a commit to facebook/chef-utils that referenced this issue Jul 14, 2020
@facebook-github-bot
Swap 'blacklist' for 'denylist' (#81)
8a8f7e6 
Summary:
In the spirit of inclusivity and non-discrimination, this PR will swap-out the use of `blacklist` for the more acceptable word `denylist`.

This PR would close-out Issue #80 on this repo (and [an issue with our of our Chef cookbooks](uber/client-platform-engineering#40) which works atop `chefctl`).

Pull Request resolved: #81

Reviewed By: nikitakoshikov

Differential Revision: D22528913

Pulled By: davide125

fbshipit-source-id: 1976b5cb560e0834b359efb0f25344c04d53402b
@mikermcneil
Copy link

More context for any other folks landing from search engines who might be new to the topic: https://about.gitlab.com/handbook/communication/top-misused-terms/#list-of-top-misused-terms

@mikermcneil
Copy link

(upstream PR got merged btw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChefAustin ChefAustin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikermcneil @ChefAustin