Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

120.0.6099.63: new chromium version #587

Closed
github-actions bot opened this issue Dec 6, 2023 · 24 comments
Closed

120.0.6099.63: new chromium version #587

github-actions bot opened this issue Dec 6, 2023 · 24 comments
Labels
release They mark releases (if I remember to put it on :)

Comments

@github-actions
Copy link

github-actions bot commented Dec 6, 2023

indicate 10 bugs, but the other 5 no-shows!

[BreakoutBox] Check validity of context before enqueuing frames.
https://chromium-review.googlesource.com/c/chromium/src/+/4997039
[BreakoutBox] Use KeepAlive to prevent lifetime race with audio delivery
https://chromium-review.googlesource.com/c/chromium/src/+/5009864

Fix region search controller using dangling browser pointer.
https://chromium-review.googlesource.com/c/chromium/src/+/4973698

so, we need to use chrome::FindBrowserWithTab(web contents)

not found

content: pass initiator origin through for context menu
https://chromium-review.googlesource.com/c/chromium/src/+/4763411

low for security but high for privacy!

@uazo uazo pinned this issue Dec 6, 2023
@uazo uazo added the release They mark releases (if I remember to put it on :) label Dec 6, 2023
@uazo
Copy link
Owner

uazo commented Dec 7, 2023

commit: 8930409
builder: https://github.com/uazo/cromite/actions/runs/7114962862
release: https://github.com/uazo/cromite/releases/tag/v120.0.6099.63-8930409029b2bd18512f65011d5a0e2ffde08225
docker image: 120.0.6099.63-8930409029b2bd18512f65011d5a0e2ffde08225

changes:

@NF075
Copy link

NF075 commented Dec 7, 2023

Request to Update of latest ref Chrome version
120.0.6099.71.
Released few hours ago.
For security fix. Windows, Linux , Mac.
Don't find or Google don't publish what security fix or bug.
If you agree, think is needed. Possible, and, you have time.
Thx...

@Miizuo
Copy link

Miizuo commented Dec 7, 2023

This is great but download speed are slow how do I fix it? Maximum I can get around 100-700kbps it suck ...I try on other browser I can get 1-12mbps

@basilgello
Copy link

basilgello commented Dec 9, 2023

@uazo I built Cromite for minsdk 24 - one change required. Mind incorporating the change into next builds?

sed -i '/default_min_sdk = /s/26/24/' $WORKSPACE/chromium/src/build/config/android/config.gni

@aliaziz7
Copy link

aliaziz7 commented Dec 9, 2023

Please add system WebView

@basilgello
Copy link

I built webview as well. Took 4 new patches to make it work.

@ramon501
Copy link

i cannot install this latest version on my android 7.1.1

@basilgello
Copy link

This version requires 8.0+. Patch is simple, but @uazo mentioned he did not want to keep dupporting 7.x. Hope he re-visits the decision.

@uazo
Copy link
Owner

uazo commented Dec 11, 2023

Patch is simple

Patch is simple, now. As soon as they remove the specific code for a7, it will no longer be.

@uazo
Copy link
Owner

uazo commented Dec 11, 2023

Took 4 new patches to make it work.

but how did you test it?

@basilgello
Copy link

  1. If you are on LineageOS, its stock browser Jelly uses WebView. If you are not, you can install jQuarks viewer (LineageOS Jelly browser +adsBlocker +tiles +offline_.mht +...)
    https://f-droid.org/packages/com.oF2pks.jquarks/

  2. Visit https://browserleaks.com/ip

  3. Check user-agent to be 120.0

@basilgello
Copy link

Patch is simple, now

I already said and can repeat again: I will be maintaining this patchset till my tablet breaks. I write this in public so other people can join our efforts.

@uazo
Copy link
Owner

uazo commented Dec 11, 2023

If you are on LineageOS, its stock browser Jelly uses WebView.

I like it, I will try it. could you show me the modifications to be made?

I already said and can repeat again: I will be maintaining this patchset till my tablet breaks

Sorry, I did not understand that.
you are welcome!

sed -i '/default_min_sdk = /s/26/24/' $WORKSPACE/chromium/src/build/config/android/config.gni

^^^ but this is not good.

I can help you set up the necessary infrastructure to generate patches, if you deem it necessary.

@basilgello
Copy link

basilgello commented Dec 11, 2023

The webview patches:

0001-android_webview-Fix-build-after-field-trials-patch.patch
0002-android-webview-Fix-autofil-and-aw_content_client.patch
0003-android_webview-Drop-AWVariationSeedFetcher-service.patch
0004-Fix-WebView-build.patch

And the ROM has to have the patch applied like here: syphyr/android_vendor_cm-1@2d9535a

The signature in this patch belongs to my key, but I will show you how to generate signature for your key.

Also I will adapt https://github.com/arovlad/bromite-webview-overlay so end-users of custom ROMs can install the flashable zip with TWRP and get working Cromite Webview. Either syphyr's patch or flashable zip will be enough to make Cromite WebView working.

Build vommand:

ninja -C out/arm64 system_webview_apk

@basilgello
Copy link

I can help you set up the necessary infrastructure to generate patches, if you deem it necessary.

Perfect. Let me format that one patch properly.

@uazo
Copy link
Owner

uazo commented Dec 11, 2023

thank you, all very interesting.
I'll finish something I'm doing and then I'll look at them. I'll let you know.

@basilgello
Copy link

Sorry, I did not understand that.

My tablet is 8 year old but there are many other people with similar devices. Even DivestOS still builds 14.1 branch using the patches that me, @syphyr, @MSe1969 and Tad are porting. While I have the tablet in my hands, I will do my best to keep it updated.

@MSe1969
Copy link

MSe1969 commented Dec 11, 2023

@basilgello is right, we work together and I'll join the efforts to make further back-ports, if necessary.

@syphyr
Copy link

syphyr commented Dec 11, 2023

I am also ready to help support nougat maintenance. Currently, 120.0.6099.63 (browser and webview) is running perfectly on nougat with no modifications to the source code, except for changing minimum supported api number. Official nougat support did not need to be dropped yet.

@uazo
Copy link
Owner

uazo commented Dec 13, 2023

@basilgello I am trying to compile. but 0004-Fix-WebView-build.patch but this patch is not very correct, because it changes the behaviour of all generate_jni() targets and I do not think this is the best solution.

diff --git a/android_webview/lib/BUILD.gn b/android_webview/lib/BUILD.gn
index b7c2d29503..8399a62339 100644
--- a/android_webview/lib/BUILD.gn
+++ b/android_webview/lib/BUILD.gn
@@ -50,6 +50,7 @@ source_set("lib") {
     "//tools/v8_context_snapshot:buildflags",
     "//ui/base",
     "//ui/events:gesture_detection",
+    "//chrome/browser/preferences:jni_headers",
   ]

I have currently corrected it this way, but it is not clear to me (for now :) why the deps is wrong.
EDIT: maybe I found it, the error is in 'Add option to force tablet UI' patch

@basilgello
Copy link

@uazo Patch 0004 was quite a hacky fix because I tried to propagate generate_final_jni = false header from bromite's gni but failed to do that. For me it looks now that generate_final_jni is not a configurable parameter but I can be wrong.

@uazo
Copy link
Owner

uazo commented Dec 13, 2023

the bug is in the patch I indicated, which is just wrong, I will solve it.

@uazo
Copy link
Owner

uazo commented Dec 14, 2023

@basilgello these are the patch changes needed for the webview build.
thank you for your persistence! You also made me find a bug in another patch

@uazo
Copy link
Owner

uazo commented Dec 14, 2023

next version #600

@uazo uazo closed this as completed Dec 14, 2023
@uazo uazo unpinned this issue Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release They mark releases (if I remember to put it on :)
Projects
None yet
Development

No branches or pull requests

8 participants