-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
120.0.6099.63: new chromium version #587
Comments
commit: 8930409 changes:
|
Request to Update of latest ref Chrome version |
This is great but download speed are slow how do I fix it? Maximum I can get around 100-700kbps it suck ...I try on other browser I can get 1-12mbps |
@uazo I built Cromite for minsdk 24 - one change required. Mind incorporating the change into next builds? sed -i '/default_min_sdk = /s/26/24/' $WORKSPACE/chromium/src/build/config/android/config.gni |
Please add system WebView |
I built webview as well. Took 4 new patches to make it work. |
i cannot install this latest version on my android 7.1.1 |
This version requires 8.0+. Patch is simple, but @uazo mentioned he did not want to keep dupporting 7.x. Hope he re-visits the decision. |
Patch is simple, now. As soon as they remove the specific code for a7, it will no longer be. |
but how did you test it? |
|
I already said and can repeat again: I will be maintaining this patchset till my tablet breaks. I write this in public so other people can join our efforts. |
I like it, I will try it. could you show me the modifications to be made?
Sorry, I did not understand that.
^^^ but this is not good. I can help you set up the necessary infrastructure to generate patches, if you deem it necessary. |
The webview patches: 0001-android_webview-Fix-build-after-field-trials-patch.patch And the ROM has to have the patch applied like here: syphyr/android_vendor_cm-1@2d9535a The signature in this patch belongs to my key, but I will show you how to generate signature for your key. Also I will adapt https://github.com/arovlad/bromite-webview-overlay so end-users of custom ROMs can install the flashable zip with TWRP and get working Cromite Webview. Either syphyr's patch or flashable zip will be enough to make Cromite WebView working. Build vommand:
|
Perfect. Let me format that one patch properly. |
thank you, all very interesting. |
@basilgello is right, we work together and I'll join the efforts to make further back-ports, if necessary. |
I am also ready to help support nougat maintenance. Currently, 120.0.6099.63 (browser and webview) is running perfectly on nougat with no modifications to the source code, except for changing minimum supported api number. Official nougat support did not need to be dropped yet. |
@basilgello I am trying to compile. but
I have currently corrected it this way, but it is not clear to me (for now :) why the deps is wrong. |
@uazo Patch 0004 was quite a hacky fix because I tried to propagate |
the bug is in the patch I indicated, which is just wrong, I will solve it. |
@basilgello these are the patch changes needed for the webview build. |
next version #600 |
indicate 10 bugs, but the other 5 no-shows!
[BreakoutBox] Check validity of context before enqueuing frames.
https://chromium-review.googlesource.com/c/chromium/src/+/4997039
[BreakoutBox] Use KeepAlive to prevent lifetime race with audio delivery
https://chromium-review.googlesource.com/c/chromium/src/+/5009864
Fix region search controller using dangling browser pointer.
https://chromium-review.googlesource.com/c/chromium/src/+/4973698
so, we need to use chrome::FindBrowserWithTab(web contents)
not found
content: pass initiator origin through for context menu
https://chromium-review.googlesource.com/c/chromium/src/+/4763411
low for security but high for privacy!
The text was updated successfully, but these errors were encountered: