-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-build for Scala.js #202
Comments
It is doable for skunk, skunk runs on Node.js :) As I mentioned in #128 (comment), this should be very easy for the actual sources. The difficulty right now are that your tests spin up Docker images directly, which will be difficult to port. If you're willing to make a change, here's two strategies:
|
We originally had the docker images external, and I felt that the move to test-containers was a definite improvement from a usability point of view. I'd be happy to consider an alternative specifically for js tests. |
TestContainers does have support for setting up arbitrary containers docker-compose files. There's also a testcontainers-node. Perhaps it's feasible to write some Scala.js testcontainers bindings to use the node/java docker-compose API depending on context? |
@alexcardell thanks for chiming in. I mentioned there's already an existing pure Scala Docker client that cross-compiles for JVM and Node.js (and will cross-compile for Scala Native as well without additional work, once its dependencies are ported). So I think investing in that is the best long-term solution, rather trying to juggle different implementations for the different platforms (dealing with npm and maintaining bindings is not much fun). |
This would benefit from #128 (comment). |
This won't work for the doobie/skunk modules, but it should be fine for the others, and it would be interesting to get other backends contributed from the node ecosystem.
The text was updated successfully, but these errors were encountered: