Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead guitar & bass code. Perhaps unify drum & taiko code #18

Open
twopointzero opened this issue Mar 11, 2020 · 0 comments
Open
Labels
chore Changes unrelated to enhancements or bug fixes

Comments

@twopointzero
Copy link
Owner

Can you write a one-sentence description of your request?
We should remove dead guitar and bass code, and consider unifying the remaining drum and taiko code paths.

What is the current behavior?
TJAPlayer3 still operates internally much like its multi-instrument origin, carrying code and executing logic related to instruments that no longer exist.

What is the expected behavior?
There should only be a single instrument code path related to taiko (or drums, but not both.)

What is the motivation / use case for changing the behavior?

  • Maintainability first and foremost
    • e.g. Significant dead code and duplicate code
    • e.g. Unnecessary conditionals and iterative code
  • Performance as a secondary concern
@twopointzero twopointzero added the chore Changes unrelated to enhancements or bug fixes label Mar 11, 2020
@twopointzero twopointzero changed the title Remove dead guitar and bass code, unify drum and taiko code Remove dead guitar and bass code, perhaps unify drum and taiko code Mar 11, 2020
@twopointzero twopointzero changed the title Remove dead guitar and bass code, perhaps unify drum and taiko code Remove dead guitar & bass code. Perhaps unify drum & taiko code Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes unrelated to enhancements or bug fixes
Projects
None yet
Development

No branches or pull requests

1 participant