Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bgw-examples] Dialog documentation is using wrong classes for the Type (AlertType instead of DialogType) #354

Open
sdwagner opened this issue Nov 23, 2022 · 0 comments · May be fixed by #393
Open

[bgw-examples] Dialog documentation is using wrong classes for the Type (AlertType instead of DialogType) #354

sdwagner opened this issue Nov 23, 2022 · 0 comments · May be fixed by #393
Labels
documentation Improvements or additions to documentation

Comments

@sdwagner
Copy link

Are you refering to KDocs or GitHub Pages?
Github Pages (https://tudo-aqua.github.io/bgw/dialogs/dialog/dialog.html)

In case of unclear documentation
In the code examples AlertType is used. AlertType does not exist (anymore). DialogType has to be used.

Additional context
AlertType is used in both Code examples. Also alertType as parameter for the constructor does not exist.
@sdwagner sdwagner added the documentation Improvements or additions to documentation label Nov 23, 2022
@finnwilken finnwilken linked a pull request Dec 6, 2023 that will close this issue
Open
@smilefx smilefx changed the title Dialog documentation is using wrong classes for the Type (AlertType instead of DialogType) [bgw-examples] Dialog documentation is using wrong classes for the Type (AlertType instead of DialogType) Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace AlertType with DialogType in code examples for dialog finnwilken/bgw
1 participant
@sdwagner