feat: disable "mouse hover focuses PCB viewer" by default #141
Conversation
…h prop focusOnHover - The default behavior for mouse hover focusing the PCB viewer has been disabled. - Added a new `focusOnHover` prop to allow enabling this feature if required.
kom-senapati
requested review from
seveibar,
ShiboSoftwareDev and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
i don't think you fixed the right behavior, to test, make sure that you create a story that has the prop, then test hovering over the PCB
Currently when you hover over the pcb viewer it refocuses the page, adjusting the scroll position. We want to disable that behavior when focusOnHover={false | undefined}
I thought its like focusOnHover={false | true | undefined} See in deployment it doesn't focus the traces which can be turned on. |
|
@kom-senapati i can show this on stream tomorrow but the issue involves focusing the pcb viewer on hover meaning the page is adjusting the scroll position to focus the pcb viewer the scroll position is changing, this is the thing we want to disable (nothing to do with traces etc.) |
|
@seveibar check this too |
focusOnHoverprop to allow enabling this feature if required./claim #139
Fixes #139