Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Nav bar is broken on desktop in smaller browser widths. #1104

Open
its-everdred opened this issue Dec 13, 2021 · 5 comments
Open

Nav bar is broken on desktop in smaller browser widths. #1104

its-everdred opened this issue Dec 13, 2021 · 5 comments
Assignees
Labels
devrel Tasks related to developer experience and developer relations good first issue priority-medium

Comments

@its-everdred
Copy link
Contributor

its-everdred commented Dec 13, 2021

Problem

Currently this happens when you are not on the homepage, click the hamburger icon in the nav on desktop when their browser is small enough for mobile nav:
broken-nav

Solution

Make sure users are can still navigate on desktop in mobile mode.

@lsqproduction
Copy link
Contributor

what browser was this? it seems ok on chrome and brave

@kevinbluer kevinbluer self-assigned this Dec 16, 2021
@fainashalts fainashalts added the devrel Tasks related to developer experience and developer relations label Jan 3, 2022
@its-everdred
Copy link
Contributor Author

I can reprod this issue in Firefox, Chrome, and Brave. It looks like "any page other than the home page" might have been too broad. I am seeing this consistently on Guide pages such as: https://trufflesuite.com/guides/drizzle-and-contract-events/index.html

@ameer-khan-ashraf
Copy link

@kevinbluer Hi is this issue still open? Just asking as it has been open 2 months ago. I would like to work on this.

@kevinbluer
Copy link
Member

Hey @ameer-khan-ashraf! 100%, that would be awesome if you're able to work on it. Let me / us know if you have any questions as you go.

Thanks in advance!

@ameer-khan-ashraf
Copy link

@kevinbluer I have applied the fix and created a pull request. Please have a look and let me know if that solves the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
devrel Tasks related to developer experience and developer relations good first issue priority-medium
Projects
None yet
Development

No branches or pull requests

5 participants