Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSD - HDD Detection #95

Open
ralequi opened this issue Feb 17, 2025 · 1 comment
Open

SSD - HDD Detection #95

ralequi opened this issue Feb 17, 2025 · 1 comment
Assignees
Labels
enhancement help wanted needs more info More info is required to continue

Comments

@ralequi
Copy link
Collaborator

ralequi commented Feb 17, 2025

On #94 , @jackeichen shown that SSD detection should be inproved.

ie. NVMe can be HDD too, and the protocol says so:

In NVMe Spec 2.0 section 5.17.2.8, I/O Command Set Independent Identify Namespace is Mandatory. Add Here is what i found: 1739765020767

I cannot say that the above method is a common type, at least two challenges here:

  1. nvme spec < 2.0 may not support CNS 08h;
  2. I can't confirm if windows could support pass through CNS 08h;

But it is not a bad ideas to add it to the code.

Should investigate further how to obtain that property

@jackeichen
Copy link
Contributor

A controller that supports namespaces that store user data on rotational media shall:

a) set the Rotational Media bit to ‘1’ in the NSFEAT field of the I/O Command Set Independent Identify Namespace data structure (refer to the NVM Command Set Specification) for any namespace that stores data on rotational media;
b) support the Rotational Media Information log page (refer to section 5.16.1.21);
c) support the Spinup Control feature (refer to section 5.27.1.22);
d) support Endurance Groups (refer to section 3.2.3); and
e) set the EG Rotational Media bit to ‘1’ in the EGFEAT field in the Endurance Group Information log page for each Endurance Group that stores data on rotational media.

If the NVM subsystem does not contain any Endurance Groups that store data on rotational media, then the Rotational Media Information Log should not be supported.

So we could check if disk support Rotational Media Information log page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted needs more info More info is required to continue
Projects
None yet
Development

No branches or pull requests

2 participants