Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable Sample Point Sizes #23

Closed
travisgoodspeed opened this issue May 7, 2023 · 3 comments
Closed

Adjustable Sample Point Sizes #23

travisgoodspeed opened this issue May 7, 2023 · 3 comments

Comments

@travisgoodspeed
Copy link
Owner

We currently sample just one pixel for each bit. This is surprisingly effective but some, particularly diffusion ROMs under good focus and magnification, require other sampling methods.

Close this issue when we can adjust the sample size, perhaps with some choices as to how the colors of the sample spot are merged.

@travisgoodspeed
Copy link
Owner Author

Example histogram of point samples on a diffusion ROM with poor separation between bit values.

Screenshot 2023-05-07 at 20 58 24

On this particular image, taking the darkest position along a thin horizontal slice would reveal the correct bit.

Screenshot 2023-05-07 at 20 59 52

@travisgoodspeed
Copy link
Owner Author

I don't yet have the bimodal distribution that I'm looking for, and sample width is critical, but a quick prototype that samples 10 bits wide successfully identifies many bits that were completely lost in the single-bit sampler. Some, of course, are still wrong, but I hope to correct this with a bit of fine tuning.

Screenshot 2023-05-07 at 22 31 22

@travisgoodspeed
Copy link
Owner Author

With the correct width, a proper bimodal distribution appears and all bits can be accurately recognized.

Screenshot 2023-05-07 at 22 39 44

Settings from my photo of the Intel 8271 ROM.

  1. 15 pixel wide sampling.
  2. Darkest of each color channel.
  3. Green is the magic channel. No bimodal distro in other channels.

We probably also want brightest of each channel for darkfield, and we probably want tall samples for when wide ones aren't appropriate. The pixel width will absolutely have to be selectable, and #25 tracks GUI changes that will be needed as we begin sampling more than one pixel per bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant