Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation Matrix for Alignment #120

Open
3 of 4 tasks
travisgoodspeed opened this issue Aug 4, 2024 · 2 comments
Open
3 of 4 tasks

Rotation Matrix for Alignment #120

travisgoodspeed opened this issue Aug 4, 2024 · 2 comments

Comments

@travisgoodspeed
Copy link
Owner

travisgoodspeed commented Aug 4, 2024

RomAlignerReliable now reliably aligns bits when the image is straight or reasonably tilted, but it becomes confused when a large gap exists between two sides of the ROM.

image

One method would be to calculate the tilt of the image from the 1st and n'th bits, then to do all comparisons from coordinates tilted in the same way.

  • RomAlignerReliable forked into RomAlignerTilting
  • Tilt detected.
  • Rotation applied to coordinates.
  • Rotation aligner becomes default.
@travisgoodspeed
Copy link
Owner Author

This aligner is now supported. See Edit / Alignment Constraints / Strategy.

@travisgoodspeed
Copy link
Owner Author

All integration tests pass when making this the default and removing RomAlignerReliable, but at the cost of ~10% of execution time. For now, I'm holding off on making it the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant