Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add things to summary.litfit #19

Open
wcornwell opened this issue Sep 25, 2015 · 4 comments
Open

add things to summary.litfit #19

wcornwell opened this issue Sep 25, 2015 · 4 comments

Comments

@wcornwell
Copy link
Contributor

coef
steadystate
time to 50 % mass loss

@j-tweed
Copy link
Contributor

j-tweed commented Sep 25, 2015

I suggest we model the summary after lm i.e. have it as a list with all possibly interesting derived values, but then also write a print method for it, so if the user just enters summary(fit) they see a nicely formatted summary. But they can still access the various components with the $ function.

Same goes for the litfit object itself. Maybe this should be a new issue...

@wcornwell
Copy link
Contributor Author

Agreed.

Did you see the commits on the bootstrap branch? I think it's working well, as far as I can tell. Do you think it's ready to merge?

@j-tweed
Copy link
Contributor

j-tweed commented Sep 25, 2015

cool, I'll have a look later today or over the weekend

On 25 September 2015 at 08:38, Will Cornwell [email protected]
wrote:

Agreed.

Did you see the commits on the bootstrap branch? I think it's working
well, as far as I can tell. Do you think it's ready to merge?


Reply to this email directly or view it on GitHub
#19 (comment)
.

wcornwell added a commit that referenced this issue Sep 27, 2015
@wcornwell
Copy link
Contributor Author

@j-tweed started work on this, so make sure to pull before you do anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants