-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google OpenID and RSS loop. #18
Comments
The RSS and iCal feeds work for me (when I click on the links using my logged-in-via-openid browser). (Trac 0.12.) Can you be more specific about exactly what "does not work" means? |
I think I can confirm this. To reproduce:
Instead of the RSS feed, you get an error page with the message: When logged out, the RSS feed works correctly. Configuration: ############################ Looking into this, it seems the problem is that the link to the RSS feed The RSS link is rendered by:
(from ticket/report.py) When logged in, the link is apparently intended to go to /login first to |
Thanks for the report @sleske . So this is a trac >= 1.0 issue. At first guess it seems the only real fix would be to implement our own replacement handler for /login — one which respects the As a hack, it may be possible to mangle the link URLs from an appropriately constructed site template — along the lines of what I describe here. Though it will be trickier to extract the real URL from the referer query arg — I suspect it's possible, but don't know quite how to do it, atm. |
Thank you Sebastian for reproducing and thank you Jeff for looking into this, currently I am trying to circumvent this by using Apache rewrite, but if anyone has a better idea I am all ears. |
Well, you could just change the line I indicated, by removing the auth_link() call. Then the link may not work for people not logged in, but it should work otherwise. Still not nice, but might help... |
Even after removing the auth_link from trac/ticket/report.py, removing report.pyc, and restarting apache, the RSS Feed link still shows up as https://mydomain.com/trac/login?referer=%2Ftrac%2Freport%2F7%3Fasc%3D1%26format%3Drss%26USER%3Dmyuser which when clicked causes my browser to go back to the openid login, it verifies my login then goes back to the page I was on without doing anything for RSS. |
I spoke too soon, there was another place I needed to remove the auth_link() call, I went ahead and did this, but the results are not what I am wanting it yields the url: https://mydomain.com/trac/report/RSS%20Feed, which of course tries to call the handler /report/RSS Feed which does not exists. I want the url to be https://mydomain.com/trac/report?asc=1&format=rss |
If you are logged into Trac using Google OpenID and go to "View Tickets" at the bottom of the page you'll see the ability to "Download in other formats" choosing Comma-delimited text or Tab-delimited text those features work fine, but if you choose RSS it does not work. This issue also occurs when going to "Roadmap" and at the bottom of the screen it has a similar option to download in iCalendar this also does not work and I believe it's because this may be a bug in the authopenid-plugin.
The text was updated successfully, but these errors were encountered: