Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MariaDB #112

Open
fmohr opened this issue Apr 11, 2023 · 0 comments
Open

Add support for MariaDB #112

fmohr opened this issue Apr 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@fmohr
Copy link
Collaborator

fmohr commented Apr 11, 2023

The MariaDB connector does not support explicit transactions. This is a bit annoying since the two database systems are usually considered to be substitutable, and MySQL is not (anymore) available in several Linux distributions. However, except from this, it works 100% identical to the MySQL connector. The cleanest solution would probably be to add a flag in the constructor of DatabaseConnectorMYSQL called explicit_transactions = True. A MariaDB connector could just inherit from this connector and set the flag to False at construction time.

@fmohr fmohr added the bug Something isn't working label Apr 11, 2023
@fmohr fmohr linked a pull request Jul 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant