Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getDirtyAttributes detect updated dynamic fields #15

Open
djagya opened this issue Jun 14, 2016 · 2 comments
Open

Make getDirtyAttributes detect updated dynamic fields #15

djagya opened this issue Jun 14, 2016 · 2 comments
Assignees

Comments

@djagya
Copy link
Collaborator

djagya commented Jun 14, 2016

Or at least just mark the field we use for dynamic fields as 'dirty'.

It will be useful in many places as for example in TimestampBehavior, that updates timestamps only if model has dirty attributes.

What do you think @tom-- ?

@djagya djagya self-assigned this Jun 14, 2016
@tom--
Copy link
Owner

tom-- commented Jun 14, 2016

I like the simpler option "mark the field we use for dynamic fields as 'dirty'."

The more specific case (distinguishing dirty and clean dynamic attributes in the tree of dyn attrs) seems complicated to implement and I'm not sure what value it has since MariaDB does not have a COLUMN_UPDATE() function and we don't use COLUMN_ADD to update individual dyn attrs.

@djagya
Copy link
Collaborator Author

djagya commented Jun 14, 2016

@tom-- sounds good, I'll handle that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants