Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add Close connection support to port 80 listener #450

Open
elBelgg opened this issue Dec 31, 2024 · 1 comment
Open

[ENHANCEMENT] Add Close connection support to port 80 listener #450

elBelgg opened this issue Dec 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@elBelgg
Copy link

elBelgg commented Dec 31, 2024

Describe the bug
If you´re using "Close connection" in Default Site, and you have enabled "Enable HTTP server on port 80" it will return 404 instead of closing the connection. If you disable it, it works as expected.

@elBelgg elBelgg added the bug Something isn't working label Dec 31, 2024
@tobychui
Copy link
Owner

@elBelgg That is in fact, the default behavior. Let me explain a bit further.

Port 80 listener is design to expose some service to legacy devices that do not support HTTPS, or for WiFi MCUs where resolving TLS / SSL might be too resources heavy. That is why the default site settings do not apply to port 80 as it should only be resolvable on specific enabled host names.

But after seeing this issue, I think it might be nice to add support for close connection as well as it might be useful for preventing IoT device based backdoor attack. So the new behavior will become

  1. If default site (primary proxy router, e.g. :443) is set to "Close Connection", requests using hostname with its http proxy rule not enabled port :80 listening will be closed
  2. else, it return 404 error (default expected behavior)

@tobychui tobychui added enhancement New feature or request and removed bug Something isn't working labels Dec 31, 2024
@tobychui tobychui changed the title [BUG] Close connection not working [ENHANCEMENT] Add Close connection support to port 80 listener Dec 31, 2024
tobychui added a commit that referenced this issue Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants