Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to define custom handler? #23

Closed
emil14 opened this issue Nov 27, 2023 · 5 comments
Closed

Is it possible to define custom handler? #23

emil14 opened this issue Nov 27, 2023 · 5 comments

Comments

@emil14
Copy link

emil14 commented Nov 27, 2023

Fix me if I'm wrong but on a client I can do client.sendRequest("foobar", {}) which mean it should be possible to defined custom handler. But looking at Handler interface implementation in the lib it looks like there's a switch that simply do return in case there is no match with predefined paths. Or Am I wrong?

@semanticart
Copy link

I'm also curious about this. Non-standard methods not super uncommon (the ruby-lsp recently added a method for getting dependencies, for instance).

@tliron
Copy link
Owner

tliron commented Feb 29, 2024

Hm, it's honestly something I did not know. I can think of a potential design for this, but very happy to review a PR to add this!

@tris203
Copy link

tris203 commented Jun 28, 2024

I am working on an implementation where I would also like this. I would be happy to work on a PR. Do you have a breif overview of the design you were thinking of for this @tliron just to make sure we are aligned?

@tliron
Copy link
Owner

tliron commented Jun 28, 2024

How about we turn this issue into a discussion and share design ideas?

@tris203
Copy link

tris203 commented Jun 28, 2024

How about we turn this issue into a discussion and share design ideas?

Sure

Repository owner locked and limited conversation to collaborators Jun 28, 2024
@tliron tliron converted this issue into discussion #31 Jun 28, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants