Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can add MyLA to a course when they have Teacher role in at least one section #1631

Open
jennlove-um opened this issue Jan 28, 2025 · 3 comments
Assignees
Labels
📈 enhancement New feature or request

Comments

@jennlove-um
Copy link
Contributor

jennlove-um commented Jan 28, 2025

Expected behavior (A description of what you expected to happen) :

When a user is enrolled in multiple sections of a course, if one of those enrollments is a teacher enrollment, then that user can add MyLA to the course.

Describe the bug (Tell us what happens instead of the expected behavior) :

When a user has a Teacher enrollment in one section and a TA enrollment in another section of a course, they are not able to add MyLA to the course. They can use the Navigation to add MyLA, but when they click on MyLA, they get the message: Course NNNNN has not been set up in MyLA. Contact your instructor, who can enable the visualizations by clicking on MyLA in the course navigation.

Steps to Reproduce :

  1. Identify a course that has a user with enrollments in multiple sections with at least one Teacher enrollment.
    a. You can also add a new user to your course with +People to these two sections and different enrollments.
  2. Add MyLA to the course from the Settings > Navigation
  3. Click on MyLA
@jennlove-um jennlove-um added the 🪳 bug Something isn't working label Jan 28, 2025
@jonespm
Copy link
Member

jonespm commented Jan 28, 2025

It looks like this was explicitly changed to work like this in #1381 and was a test case to pass. There is a comment in the code.

# Checking if user only has Instructor role in a course to enable MyLA in courses.
# A TA could be an instructor in an course section so his role will be both TA and Instructor.
# we don't want TA to enable the MyLA data extraction step.

@jennlove-um
Copy link
Contributor Author

jennlove-um commented Jan 29, 2025 via email

@jennlove-um jennlove-um added 📈 enhancement New feature or request and removed 🪳 bug Something isn't working labels Jan 29, 2025
@jonespm
Copy link
Member

jonespm commented Jan 29, 2025

It looks like it might actually have been done 5 years ago in #982. I'm not sure if this was done for passing the certification or if we'd made this decision back then.

I'm not sure what issues a user having 2 roles in a course might cause. As long as it doesn't have any issues with the certification this is a pretty straightforward change if we were to do this. We might want to put it behind a setting incase some schools didn't want this.

We also wanted to rewrite LTI to use the Academic Innovation library as mentioned on #1304 but not sure when/if that would happen, but this seems like a smaller somewhat related to that.

@pushyamig pushyamig moved this from To do to In progress in MyLA 2025.01.01 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

3 participants