Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extrinsic_calibration_manager can‘t find! #169

Closed
0116lhc opened this issue Apr 24, 2024 · 12 comments
Closed

extrinsic_calibration_manager can‘t find! #169

0116lhc opened this issue Apr 24, 2024 · 12 comments
Assignees

Comments

@0116lhc
Copy link

0116lhc commented Apr 24, 2024

The package extrinsic_calibration_manager cannot be found in the sensor folder. I've pulled the code several times but it's still missing. Could you please confirm the location of this package?

@knzo25
Copy link
Collaborator

knzo25 commented Apr 24, 2024

Hi, that is because the extrinsic calibration manager is no longer.
Now we have a different one called sensor calibration manager, but the documentation is currently being written in #164

@knzo25 knzo25 self-assigned this Apr 24, 2024
@yoepav
Copy link

yoepav commented May 24, 2024

Hello Kenzo,

Can I follow the current documentation for manual calibration and change the steps regarding the extrinsic_calibration_manager directory for the sensor_calibration_manager directory?

@knzo25
Copy link
Collaborator

knzo25 commented May 24, 2024

Hi,
Thank you for using our tools. Sadly, I am not the maintainer of the manual calibration tool, so its use under the new scheme will need to wait until the maintainer ports the tool to the new API (or, if you prefer, you could use a previous version of the repository that is compatible with the manual tool)

@yoepav
Copy link

yoepav commented May 28, 2024

Hi Kenzo,

I tried using the main branch instead of the tier4/universe branch but sadly that doesn't work. So I guess I'll have to wait for the port. Thank you very much anyway.

@dtonda8
Copy link

dtonda8 commented Jul 7, 2024

Hi @yoepav & @0116lhc,

The latest Autoware.Universe repo had some package renaming, which causes the rosdep dependency issues you've listed.

I've forked the CalibrationTools repo with the correct dependency package naming and no longer experience the dependency issues. My fork also reverted to the older version CalibrationTools (i.e. with extrinsic_calibration_manager and aip_x1 directory). I hope this can be useful untill the re-written calibration docs are ready.

@TimDing-aoi
Copy link

Hi @yoepav & @0116lhc,

The latest Autoware.Universe repo had some package renaming, which causes the rosdep dependency issues you've listed.

I've forked the CalibrationTools repo with the correct dependency package naming and no longer experience the dependency issues. My fork also reverted to the older version CalibrationTools (i.e. with extrinsic_calibration_manager and aip_x1 directory). I hope this can be useful untill the re-written calibration docs are ready.

Hello dtonda, thanks for the upload, I have tried your version of the calibration tools but fails to colcon build.
Screenshot from 2024-08-15 14-01-22
Do you know what might be the reason for this?

@dtonda8
Copy link

dtonda8 commented Aug 15, 2024

Hi @TimDing-aoi, I've created a new issue for this in my fork (it's most likely due to Calibration repos referring to incorrect package naming). If you find out where exactly the issue lies and resolve it, you can create a pr. I will also look into this when I am free.

Edit: rosdep issues resolved, colcon build should work

@knzo25
Copy link
Collaborator

knzo25 commented Aug 19, 2024

@dtonda8
I am pretty sure the code in this PR works
#164

@dtonda8
Copy link

dtonda8 commented Aug 19, 2024

Yes, that pr seems to work. The only issue is that you'll need to switch to a slightly older version of autoware.universe, otherwise the output of rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO is this:
Pasted image 20240820075540

Autoware.universe recently renamed kalman_filter to autoware_kalman_filter in this commit
So we should git checkout to a commit before that (fd09a5b)
Pasted image 20240820080520

@knzo25
Copy link
Collaborator

knzo25 commented Aug 20, 2024

@dtonda8
I just updated the PR branch to be compatible with the latest universe (1dfc8d7)

@dtonda8
Copy link

dtonda8 commented Aug 20, 2024

@knzo25 Legend! Thanks for doing that. To everyone else looking for a CalibrationTools version compatible with the latest Autoware and matches the current extrinsic_calibration_manager docs, please use knzo25's pr branch.

@knzo25
Copy link
Collaborator

knzo25 commented Sep 24, 2024

These issues should disappear in the main branch now
#164

@knzo25 knzo25 closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants