Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): optimize click event #14154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ios): optimize click event #14154

wants to merge 1 commit into from

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Dec 13, 2024

fixes #14051

const win = Ti.UI.createWindow();
win.addEventListener("click", function(e) {
	console.log("click")
})


win.open();

This was my initial idea to improve the click event.

Currently it only uses "click" and "dblclick" but if you continue to click it won't fire click events. More info in the issue #14051

@m1ga m1ga requested a review from hansemannn December 13, 2024 10:24
@hansemannn
Copy link
Collaborator

I honestly don't feel very confident right now merging something so sensitive again right now, for two reasons:

  1. The first one broke quite many apps after being unnoticed during CR
  2. I didn't see many devs raging against the current way it works, neither with performance issues or non-native behaviors

Therefore, I would either ask for a community feedback to understand what issues they have (we don't have any for example and none of our users ever reported something like slow click behavior) or keep it as-is for now.

@m1ga
Copy link
Contributor Author

m1ga commented Jan 29, 2025

sounds good. Think most people used the singleTap on iOS if they wanted to have faster click events (+/- buttons) in the past instead of click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn Awaiting requested review from hansemannn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS: can click speed be improved?
2 participants
@m1ga @hansemannn