edk2-libc: Remove use of weak symbols from StdLib to resolve conflict with /WHOLEARCHIVE when building SocketDxe (Bugzilla Bug 3572)

[tianocore-issues]

This issue was created automatically with bugzilla2github

Bugzilla Bug 3572

Date: 2021-08-18T17:22:14+00:00
From: @mdkinney
To: @mdkinney
CC: @lgao4

Last updated: 2021-08-24T22:01:47+00:00

[tianocore-issues]

Comment 16966

Date: 2021-08-18 17:22:14 +0000
From: @mdkinney

• Industry Specification: ---
• Release Observed: EDK II Master
• Releases to Fix: EDK II Master
• Target OS: ---
• Bugzilla Assignee(s): @mdkinney

StdLib/EfiSocketLib in edk2-libc repo uses __attribute((weak)) for the
following symbols:

useefisocketlib.c:CONST EFI_GUID mEslIp4ServiceGuid attribute((weak)) = {
useefisocketlib.c:CONST EFI_GUID mEslIp6ServiceGuid attribute((weak)) = {
useefisocketlib.c:CONST EFI_GUID mEslTcp4ServiceGuid attribute((weak)) = {
useefisocketlib.c:CONST EFI_GUID mEslTcp6ServiceGuid attribute((weak)) = {
useefisocketlib.c:CONST EFI_GUID mEslUdp4ServiceGuid attribute((weak)) = {
useefisocketlib.c:CONST EFI_GUID mEslUdp6ServiceGuid attribute((weak)) = {
useefisocketlib.c:CONST EFI_SERVICE_BINDING_PROTOCOL mEfiServiceBinding attribute((weak)) = {
useefisocketlib.c:PFN_ESL_xSTRUCTOR mpfnEslConstructor attribute((weak)) = EslServiceNetworkConnect; ///< Constructor for EfiSocketLib
useefisocketlib.c:PFN_ESL_xSTRUCTOR mpfnEslDestructor attribute((weak)) = EslServiceNetworkDisconnect; ///< Destructor for EfiSocketLib

When this lib is linked against StdLib/SocketDxe multiple symbol errors
are generated from the use of the /WHOLEARCHIVE linker option.

weak symbol linking should no be used in edk2 repos, so this reason for
adding these needs to be investigated to produce a design change that
does not depend on weak symbols.

[tianocore-issues]

Comment 17047

Date: 2021-08-24 22:01:47 +0000
From: @lgao4

Michael will check it.