Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot manually specify ntransits #32

Closed
cbrisboi opened this issue Jan 9, 2020 · 6 comments · May be fixed by #43
Closed

Cannot manually specify ntransits #32

cbrisboi opened this issue Jan 9, 2020 · 6 comments · May be fixed by #43
Labels
no-issue-activity

Comments

@cbrisboi
Copy link
Contributor

cbrisboi commented Jan 9, 2020

In liff, you could specify the transits to use for the maps during analysis. I just noticed while working on an unrelated task that we cannot do the same for hal.

This should be straightforward to implement, a good task for a graduate student wanting to learn. Otherwise, I'll get to it eventually
@cbrisboi cbrisboi mentioned this issue Dec 17, 2020
Open
@github-actions
Copy link

This issue has become stale. Is there an update? We will close in 14 days

@maloneka
Copy link
Contributor

@cbrisboi is anyone actively working on this? This would be nice to have as we work on validation of pass 5 with the Crab strip.

@henrikef
Copy link
Contributor

@maloneka There is a branch that implements this functionality (see #43 ). Feel free to test that branch on the Crab strip etc! It still needs unit tests for the new functionality before it can be merged to the master, though.

@github-actions
Copy link

This issue has become stale. Is there an update? We will close in 14 days

@maloneka
Copy link
Contributor

@cbrisboi status update? Does this pass the tests yet?

@github-actions
Copy link

This issue has become stale. Is there an update? We will close in 14 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify ntransits cbrisboi/hawc_hal
3 participants
@henrikef @cbrisboi @maloneka