Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Edit Teams UI #6083

Open
saranshgrover opened this issue Mar 17, 2021 · 1 comment
Open

Improve Edit Teams UI #6083

saranshgrover opened this issue Mar 17, 2021 · 1 comment
Labels
AREA: UI/UX design META: good second issue More involved than first issue, these help get a deeper understanding of the codebase

Comments

@saranshgrover
Copy link
Member

Related: #4430

The UI for editing teams is quite non-trivial and tricky as the text above it mentions. While most leaders would know how to, and can be trusted to make sure it works well - its still a good idea to make the UI more easy to understand, and less prone to errors.

@Jambrose777
Copy link
Contributor

One recommendation I have for this is to distinguish 2 different types of edits: update and a fix.

  • A fix is correcting data (Ie the start date of someone is wrong)
  • An update is a change in someones position on the team (being added to the team, senior and leader promotion in the team, and demotions)

Maybe a branching pattern of saying what you want to do as there are a finite amount of things that a leader would need to do.

Also a quick side note: The current UI does not support deleting. I personally support not allowing this action as our history is kept in the teams tables, and reserving this for admins only. But it is a point of discussion if someone has arguments for it.

@saranshgrover saranshgrover added AREA: UI/UX design META: good second issue More involved than first issue, these help get a deeper understanding of the codebase labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AREA: UI/UX design META: good second issue More involved than first issue, these help get a deeper understanding of the codebase
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants