Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silence a deprecation warning in tests #2776

Closed
jku opened this issue Jan 31, 2025 · 1 comment
Closed

silence a deprecation warning in tests #2776

jku opened this issue Jan 31, 2025 · 1 comment
Labels
urllib3-migration

Comments

@jku
Copy link
Member

jku commented Jan 31, 2025

After #2762 we get a deprecation warning in tests:

/home/runner/work/python-tuf/python-tuf/.tox/py/lib/python3.13/site-packages/urllib3/_request_methods.py:182: DeprecationWarning: URLs without a scheme (ie 'https://') are deprecated and will raise an error in a future version of urllib3. To avoid this DeprecationWarning ensure all URLs start with 'https://' or 'http://'. Read more in this issue: urllib3/urllib3#2920

According to NicholasTanz tests in the code base were intentionally using no scheme/host to trigger error handling logic. Let's silence the warning somehow -- or possibly remove the schemeless test?
@jku jku mentioned this issue Jan 31, 2025
Merged
NicholasTanz added a commit to NicholasTanz/python-tuf that referenced this issue Feb 12, 2025
@NicholasTanz
swap invalid urls that are used in testing. (takes care of deprecatio…
6318760 
…n warning in theupdateframework#2776)

Signed-off-by: NicholasTanz <[email protected]>
@jku
Copy link
Member Author

jku commented Feb 14, 2025

this was fixed in #2762

@jku jku closed this as completed Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
urllib3-migration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jku