Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that bigtest has test files to run against #812

Open
dagda1 opened this issue Feb 3, 2021 · 1 comment
Open

Validate that bigtest has test files to run against #812

dagda1 opened this issue Feb 3, 2021 · 1 comment

Comments

@dagda1
Copy link
Contributor

dagda1 commented Feb 3, 2021

The bug that was raised for #800 has this testFiles glob:

 "testFiles": [  "src/**/*.test.{ts,js}"],

The correct directory is test and not src.

This is further complicated by the fact that the glob "testFiles": [ "src/**/*.test.{ts,js}"], actually found a match but it was a jest test.

import { waitFor } from './helpers';

describe('waitFor', () => {
 it('should wait for true', async () => {
   const fn = jest.fn().mockReturnValue(true);
// etc.

I definitely do not think this is a one-off and we should fail early if bigtest:

  • finds no tests
  • finds no bigtest tests

Descriptive console warnings should highlight what is wrong

@minkimcello
Copy link
Contributor

Is this related to #635?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants