systempool_size doesn't consider spare capacity

[infernix]

Example:

SDS Summary:
...
	990.0 GB (1013750 MB) total capacity
	647.3 GB (662829 MB) unused capacity
	16.0 GB (16384 MB) in-use capacity
	16.0 GB (16384 MB) protected capacity
...
	326.7 GB (334537 MB) spare capacity
	16.0 GB (16384 MB) at-rest capacity

systempool_size returns total 1013750mb, used 16384mb, free 997366mb.

So the calculation total-used=free is off since spare capacity cannot be considered allocateable (e.g. free) space.

[infernix]

Here's probably the better query for a valid value:

params = {'selectedStatisticsList': [{'type': 'System', 'allIds': '', 'properties': [ 'unusedCapacityInKb','capacityAvailableForVolumeAllocationInKb','spareCapacityInKb']}]}
req = cluster._post('/api/instances/querySelectedStatistics', params=params)

You can then either do total - used - spare to arrive at the same figure as unusedCapacityInKb, but probably a better figure to use for free space is capacityAvailableForVolumeAllocationInKb since you can never allocate more space than that.

[ftersin]

Thanks. We'll deal with that soon.

[ftersin]

Fixed in branches of https://github.com/codedellemc/python-scaleioclient (except master branch).