-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace go-ble/ble with tinygo-org/bluetooth #373
Open
Lenart12
wants to merge
19
commits into
teslamotors:main
Choose a base branch
from
Lenart12:tinygo-bluetooth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
26df6aa
Switch BLE to use tinygo-org/bluetooth module
Lenart12 84f778f
Add small test-ble utillity
Lenart12 6948c33
Add option to specify BT device ID for `tesla-control`
Lenart12 8e99965
Fix scan not stopping if context was canceled before starting
Lenart12 055ef3f
Ensure Scan() completes before returning from scanVehicleBeacon
Lenart12 7ba27d5
Show correct help message with adapter errors
Lenart12 a66bf81
Fix imports
Lenart12 4010467
Rename `bt-adapter` flag and only show it on Linux
Lenart12 58ec842
Rename `NewConnectionFromScanResult`
Lenart12 ea90c8b
Replace excessive debug print in `scanVehicleBeacon`
Lenart12 a5c4149
Only disable rx notifications on linux
Lenart12 52a4fb1
Specify write type depending on platform
Lenart12 46d9ace
Merge `test-ble` with `ble` example
Lenart12 11283fd
Prevent hanging on closed channel
Lenart12 635c730
Fix typo in ble example
Lenart12 710b530
Fix possible deadlock in tryToConnect
Lenart12 c2859bf
Rename unused parameters
Lenart12 e166ac6
Fix scan getting stuck if adapter gets restarted during scan, again...
Lenart12 0aafe21
Bump bluetooth library to include some linux fixes
Lenart12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package cli | ||
|
||
func (c *Config) registerCommandLineFlagsOsSpecific() { | ||
// Nothing yet | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package cli | ||
|
||
import "flag" | ||
|
||
func (c *Config) registerCommandLineFlagsOsSpecific() { | ||
if c.Flags.isSet(FlagBLE) { | ||
flag.StringVar(&c.BtAdapterID, "bt-adapter", "", "ID of the Bluetooth adapter to use. Defaults to hci0.") | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package cli | ||
|
||
func (c *Config) registerCommandLineFlagsOsSpecific() { | ||
// Nothing yet | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well fix "simplicity" typo next time you do a push