Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dependency on snappy #118

Open
judah opened this issue May 12, 2017 · 0 comments
Open

Remove the dependency on snappy #118

judah opened this issue May 12, 2017 · 0 comments

Comments

@judah
Copy link
Contributor

judah commented May 12, 2017

Our bindings currently link against the snappy C library due to the dependency on snappy-framing. As far as I can tell, the only reason we use that library is for Data.Digest.CRC32C which is pure Haskell code and doesn't actually use that C dependency.

The snappy and snappy-framing packages are also currently not in Stackage, which prevents tensorflow-records and tensorflow-records-conduit from being there as well.

As suggested in the code, one option is to split out the crc32c functionality into its own package.
judah added a commit to judah/tensorflow-haskell that referenced this issue May 16, 2017
@judah
Add extra-lib-dirs back into .cabal for Mac builds.
783df14 
Also bump the version to 0.1.0.2.

Originally we had `extra-lib-dirs: /usr/local/lib` in stack.yaml.
I removed it because it wasn't necessary on my Mac.  However,
it turns out that it is necessary for machines with the default installation
of XCode, which *doesn't* search that path by default.

(On my machine, I had run `xcode-select --install` which adds that path
permanently to your search path, which is why it wasn't necessary for me
anymore.)

I'm adding the setting back to `tensorflow.cabal` file instead of `stack.yaml`
so that the Hackage release also contains this fix.  Unfortunately, the
`snappy` package (which `tensorflow-records` depends on) won't benefit from
that fix and might run into the same issue.  Hopefully that will go away once
we remove the dependency (tensorflow#118).
judah added a commit to judah/tensorflow-haskell that referenced this issue May 16, 2017
@judah
Add extra-lib-dirs back into .cabal for Mac builds.
e7e6727 
Also bump the version to 0.1.0.2.

Originally we had `extra-lib-dirs: /usr/local/lib` in `stack.yaml`.
I removed it because it wasn't necessary on my Mac.  However,
it turns out that it is necessary for machines with the default installation
of XCode, which *doesn't* search that path by default.

(On my machine, it wasn't necessary because I had run `xcode-select --install`
which adds that path permanently to your search path.)

I'm adding the setting back to `tensorflow.cabal` file instead of `stack.yaml`
so that the Hackage release also contains this fix.  Unfortunately, the
`snappy` package (which `tensorflow-records` depends on) won't benefit from
that fix and might run into the same issue.  Hopefully that will go away once
we remove the dependency (tensorflow#118).
judah added a commit to judah/tensorflow-haskell that referenced this issue May 16, 2017
@judah
Add extra-lib-dirs back into .cabal for Mac builds.
712ad28 
Also bump the version to 0.1.0.2.

Originally we had `extra-lib-dirs: /usr/local/lib` in `stack.yaml`.
I removed it because it wasn't necessary on my Mac.  However,
it turns out that it is necessary for machines with the default installation
of XCode, which *doesn't* search that path by default.

(On my machine, it wasn't necessary because I had run `xcode-select --install`
which adds that path permanently to your search path.)

I'm adding the setting back to `tensorflow.cabal` instead of `stack.yaml`
so that the Hackage release also contains this fix.  Unfortunately, the
`snappy` package (which `tensorflow-records` depends on) won't benefit from
that fix and might run into the same issue.  Hopefully that will go away once
we remove the dependency (tensorflow#118).
judah added a commit to judah/tensorflow-haskell that referenced this issue May 16, 2017
@judah
Add extra-lib-dirs back into .cabal for Mac builds.
007ab6d 
Also bump the version to 0.1.0.2.

Originally we had `extra-lib-dirs: /usr/local/lib` in `stack.yaml`.
I removed it because it wasn't necessary on my Mac.  However,
it turns out that it is necessary for machines with the default installation
of XCode, which *doesn't* search that path by default.

(On my machine, it wasn't necessary because I had run `xcode-select --install`
which adds that path permanently to your search path.)

I'm adding the setting back to `tensorflow.cabal` as well as `stack.yaml` so
that the Hackage release also contains this fix.  Changing `stack.yaml` is
still necessary in order to fix linkage in the `snappy` package (which
`tensorflow-records` depends on).  Hopefully that will go away once we remove
the dependency (tensorflow#118).
@judah judah mentioned this issue May 16, 2017
Merged
judah added a commit to judah/tensorflow-haskell that referenced this issue May 16, 2017
@judah
Add extra-lib-dirs back into .cabal for Mac builds.
5280a0e 
Also bump the version to 0.1.0.2.

Originally we had `extra-lib-dirs: /usr/local/lib` in `stack.yaml`.
I removed it because it wasn't necessary on my Mac.  However,
it turns out that it is necessary for machines with the default installation
of XCode, which *doesn't* search that path by default.

(On my machine, it wasn't necessary because I had run `xcode-select --install`
which adds that path permanently to your search path.  For more context, see
Homebrew/brew#556.)

I'm adding the setting back to `tensorflow.cabal` as well as `stack.yaml` so
that the Hackage release also contains this fix.  Changing `stack.yaml` is
still necessary in order to fix linkage in the `snappy` package (which
`tensorflow-records` depends on).  Hopefully that will go away once we remove
the dependency (tensorflow#118).
judah added a commit that referenced this issue May 16, 2017
@judah
Add extra-lib-dirs back into .cabal for Mac builds. (#122)
d98e5d6 
Also bump the version to 0.1.0.2.

Originally we had `extra-lib-dirs: /usr/local/lib` in `stack.yaml`.
I removed it because it wasn't necessary on my Mac.  However,
it turns out that it is necessary for machines with the default installation
of XCode, which *doesn't* search that path by default.

(On my machine, it wasn't necessary because I had run `xcode-select --install`
which adds that path permanently to your search path.  For more context, see
Homebrew/brew#556.)

I'm adding the setting back to `tensorflow.cabal` as well as `stack.yaml` so
that the Hackage release also contains this fix.  Changing `stack.yaml` is
still necessary in order to fix linkage in the `snappy` package (which
`tensorflow-records` depends on).  Hopefully that will go away once we remove
the dependency (#118).
judah added a commit that referenced this issue May 16, 2017
@judah
Add extra-lib-dirs back into .cabal for Mac builds. (#122)
8bb0d2c 
Also bump the version to 0.1.0.2.

Originally we had `extra-lib-dirs: /usr/local/lib` in `stack.yaml`.
I removed it because it wasn't necessary on my Mac.  However,
it turns out that it is necessary for machines with the default installation
of XCode, which *doesn't* search that path by default.

(On my machine, it wasn't necessary because I had run `xcode-select --install`
which adds that path permanently to your search path.  For more context, see
Homebrew/brew#556.)

I'm adding the setting back to `tensorflow.cabal` as well as `stack.yaml` so
that the Hackage release also contains this fix.  Changing `stack.yaml` is
still necessary in order to fix linkage in the `snappy` package (which
`tensorflow-records` depends on).  Hopefully that will go away once we remove
the dependency (#118).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judah