Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multi-stage builds in dockerbuilder #1

Open
Cryptophobia opened this issue Mar 13, 2018 · 0 comments
Open

Support for multi-stage builds in dockerbuilder #1

Cryptophobia opened this issue Mar 13, 2018 · 0 comments

Comments

@Cryptophobia
Copy link
Member

Provide guides and instructions on how to update a cluster's Docker version so that the Dockerbuilder component can use multi-stage builds:

https://docs.docker.com/develop/develop-images/multistage-build/


In https://github.com/deis/builder/blob/master/pkg/gitreceive/k8s_util.go
"this is the code that sets up the environment to run a deis/dockerbuilder pod. Then it hands off control essentially to a dockerbuilder image, and it calls Docker through a python client from https://github.com/deis/dockerbuilder/blob/master/rootfs/deploy.py

Maybe in that code you could at least detect if the Docker version was >= 17.05 and give a warning or disallow multi-stage builds. Or maybe Docker would already handle that for you."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant