-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: use ecmarkup formatter #2623
Comments
Re: rebase pain, rebases of this kind can be completely automated, so shouldn't be too bad. That said, right now Temporal uses multi-line records in source, which ecmarkup doesn't explicitly support, so you may want to hold off on running the formatter until it does (or stop using them, or something). |
If I understand what you mean by "multi-line records" then we already use them inconsistently, so it's probably not too bad to drop them. |
What's a multi-line record? |
Writing a record on multiple lines, like this. |
Related: tc39/ecmarkup#513 |
Meeting 2023-08-17: We'll make this change in CI to add the formatter, but only after the big in-flight PRs have been merged. |
Since we currently have no spec PRs open, this is a good time to look into this. |
From tc39/ecmarkup#536 (comment):
As we get closer to Stage 4, it may be helpful to transform our spec text into the standard format used in ECMA-262, so that diffs will be cleaner.
That said, it will create a huge one-time diff when it's run for the first time, so we should pick a time to start formatting when there are no huge PRs pending, in order to reduce any rebase pain for in-progress PRs.
The text was updated successfully, but these errors were encountered: