Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential regression in JavaScriptCore support #114

Open
jugglinmike opened this issue Jun 15, 2021 · 0 comments
Open

Potential regression in JavaScriptCore support #114

jugglinmike opened this issue Jun 15, 2021 · 0 comments

Comments

@jugglinmike
Copy link
Contributor

A recent change to the JavaScriptCore "agent" may have regressed JSC support. Commit 4e9c3ee (which was first released in eshost version 8.0.0) includes the following modification

-  let env = Object.assign({}, process.env, { DYLD_FRAMEWORK_PATH });
   this.cpOptions = {
-    env
+    ...process.env,
+    DYLD_FRAMEWORK_PATH
   };
 }

Prior to that change, the object assigned to this.cpOptions had a single property, and that property was named env. The change caused this.cpOptions to become the value which was previously defined as the env property. As far as I can tell, none of the references to the property were updated to reflect this change.

I have not observed any regressions related to this change since the release of version 8.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant