-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multipage should be more accessible #631
Comments
Related #195 |
It's linked in the very first text in the body of the page: I know people tend to gloss over the frontmatter, but it is at least there. Not as helpful when you're jumping to a specific term, of course.
I believe HTML rendering blocks the main thread, so I don't know that messing with the placement of the script would have any effect (because it can't run the shortcut event handler until after the main thread is unblocked), but I could be wrong; if you want to experiment and find that it does work I'd happily take a PR. Alternatively, we could have some way of indicating that the user would prefer to always be redirected to the multipage version, and do that check+redirect in a blocking script at the beginning of the page. |
Having an input that sets a cookie and indicates the user's preference (for both always multipage, or never multipage) would be great. (Since I don't use Chrome, I don't have any slowness with the single-page version, so I always prefer single-page for the find-in-page capability) |
Thanks; acknowledged and updated.
Indeed.
Confirmed on both Chrome and Firefox that
I am in favor of this as well, and have added it to the description.
@ljharb See «on a Chrome DevTools "Slow 4G" connection» in the issue description; this is about efficiency of transferring content rather than in dealing with it after the fact. |
ah, fair enough. i'd still rather wait for the single-page load rather than lose out on find-in-page, personally :-) but that's what configuration is for. |
Having multipage support is great, but it should be more accessible... for example, loading the single-page https://tc39.es/ecma262/ from a linked term in https://tc39.es/ecma402/ or loading a build preview such as https://ci.tc39.es/preview/tc39/ecma262/pull/3513 from a GitHub Actions CI link on a Chrome DevTools "Slow 4G" connection:
never indicatesdoes not highlight the presence of a multipage alternativeThe "
never indicatesdoes not highlight multipage" issue could be solved with a floating link, possibly cleared/moved/otherwise de-emphasized on completion of page load (cf. https://html.spec.whatwg.org/ ).The "after HTML has been parsed" issues stem from use of
<script defer>
, which I think would be better behaved as<script async>
or possibly even loadingdoShortcut
as a blocking script before the body (and probably updating it to tolerate an undefinedidToSection
).The re-navigation issue is the smallest of these, but could be solved by loading multipage.js (specifically for
idToSection
and the re-navigation logic) even on the single-page view for use bydoShortcut
.And as suggested below, a cookie to force either single-page or multi-page with a check and redirection in a blocking script at the beginning of the page would preempt the need for any future interaction at all.
The text was updated successfully, but these errors were encountered: