Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height and width inversion #35

Open
zone47 opened this issue Feb 1, 2017 · 8 comments
Open

Height and width inversion #35

zone47 opened this issue Feb 1, 2017 · 8 comments

Comments

@zone47
Copy link

zone47 commented Feb 1, 2017

Hello,
Thanks for the dataset. After looking in some records, it seems that there is an inversion with width and height in JSON collection records.
Best regards

@sebastfr
Copy link
Contributor

sebastfr commented Feb 1, 2017

@zone47 thank you for your feedback - do you have any examples please?

@zone47
Copy link
Author

zone47 commented Feb 1, 2017

here : https://github.com/tategallery/collection/blob/master/artworks/p/015/p01505-11583.json
or here : https://github.com/tategallery/collection/blob/master/artworks/t/005/t00505-13260.json
All records with height and width, actually.
For example :
http://www.tate.org.uk/art/artworks/turner-a-standing-male-nude-with-right-arm-raised-seen-from-behind-d00202
https://github.com/tategallery/collection/blob/master/artworks/d/002/d00202-27618.json
"dimensions": "support: 514 x 349 mm",
"height": "349"
"width": "514"
It's the opposite : height 514mm and width 349mm
For " 514 x 349 mm", in art history it is usual to set height before width.

@sebastfr
Copy link
Contributor

sebastfr commented Feb 1, 2017

@zone47 you are correct, i suspect our script generating the data got it wrong - i will try to schedule to have the data updated. Again, thank you for getting in touch, much appreciated!

@zone47
Copy link
Author

zone47 commented Feb 1, 2017

Thank you for your reactivity! It's a great dataset (perimeter of the collection and quality). There is always some things to improve or correct but it is already very useful and I'm very happy that it is reused ( https://www.wikidata.org/wiki/Wikidata:WikiProject_sum_of_all_paintings/Collection/Tate ).

@sebastfr
Copy link
Contributor

sebastfr commented Feb 1, 2017

@zone47 and thanks for sharing that link, that's really cool! - we do use wikidata's data to hook up some of "Tate artists" to other datasets :-) this is just awesome.

@multichill
Copy link

Tate artists, right, we still have to match a couple of them, see https://www.wikidata.org/wiki/Wikidata:Database_reports/Complex_constraint_violations/P2741

BTW, the program I used to add the paintings is at https://github.com/multichill/toollabs/blob/master/bot/wikidata/tate_import.py

@sebastfr
Copy link
Contributor

sebastfr commented Feb 6, 2017

@multichill I'm happy to help if you think i can contribute (also we could work on a fresher batch of data). let me know?

@multichill
Copy link

Update of the data would be really nice! That would enable me to fix the swapped width/height on our side and maybe add some new works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants