Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous #28

Open
anton-karlovskiy opened this issue Jan 24, 2021 · 2 comments
Open

Miscellaneous #28

anton-karlovskiy opened this issue Jan 24, 2021 · 2 comments
Assignees

Comments

@anton-karlovskiy
Copy link
Member

anton-karlovskiy commented Jan 24, 2021

@pi0 @danielroe

Could you please teach me one thing in Vue.js development?
Our project has SASS preprocessor set up and re-uses the same classes across different components.
composition
According to a best practice in React componentizing (https://create-react-app.dev/docs/adding-a-sass-stylesheet/), the approach mentioned above is not recommended and I also found that such an approach might make it difficult to maintain the project.
Is it also true in Vue.js world?

@anton-karlovskiy anton-karlovskiy self-assigned this Jan 24, 2021
@danielroe
Copy link
Member

@anton-karlovskiy I would personally only put reset CSS in a global CSS context. I would put other classes in the components that use them - or use CSS modules to share styles across components in exceptional circumstances.

In most cases the latter isn't required - having good design tokens that can be referenced through variables throughout the codebase brings the required consistency.

@anton-karlovskiy
Copy link
Member Author

@danielroe
Thank you for teaching.

In most cases the latter isn't required - having good design tokens that can be referenced through variables throughout the codebase brings the required consistency.

It sounds like it's also true in Vue.js world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants