Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add a helm chart for use in k8s #581

Closed
s0ko1ex opened this issue Nov 1, 2024 · 2 comments · Fixed by #630
Closed

Feature: Add a helm chart for use in k8s #581

s0ko1ex opened this issue Nov 1, 2024 · 2 comments · Fixed by #630
Labels
type:feature_request Feature request

Comments

@s0ko1ex
Copy link

s0ko1ex commented Nov 1, 2024

Hi @tarampampam, thank you for the useful service! I'd like to add files for a helm chart to conveniently deploy your service in Kubernetes clusters and test webhooks from inside them, which can make life easier for many folks like me.

@s0ko1ex s0ko1ex mentioned this issue Nov 1, 2024
4 tasks
@tarampampam tarampampam added the type:feature New feature label Feb 1, 2025
@tarampampam
Copy link
Owner

Hi there @s0ko1ex!

First of all, I want to sincerely thank you for motivating me to deepen my knowledge of Kubernetes far beyond what I knew before. This is the main reason your PR hasn't been merged yet. To gain more experience, I attempted to create a Helm chart for this app on my own.

Your solution is well-crafted, but I found a few areas that could be improved, and I believe I have successfully made those enhancements (though I'm not entirely sure—but I'd like to think so!).

Could you review my changes in #630? If you find them useful, we can merge them. Otherwise, we can revisit your PR and work on improving it further. What do you think?

@tarampampam tarampampam added type:feature_request Feature request and removed type:feature New feature labels Feb 1, 2025
@tarampampam
Copy link
Owner

Merged & released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature_request Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants