Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM-15] Upgrade to ethers v6 #371

Closed
sanderpick opened this issue Mar 28, 2023 · 5 comments
Closed

[EVM-15] Upgrade to ethers v6 #371

sanderpick opened this issue Mar 28, 2023 · 5 comments
Assignees
Labels
Improvement Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync

Comments

@sanderpick
Copy link
Member

Now that Ethers v6 has been released we should start to work towards using it here so that the SDK can upgrade to v6.
There will be some complexity in upgrading. This package has ethers as a dev dependency, and some of the other dev dependencies mark ethers as a peer dependency. Those peer dependencies all currently have ethers v5 tagged. Looking at the github repos for these packages makes it seem like they are all going to have versions that use v6 coming out soon.
We should be ready for all those upgrades here.

related:
NomicFoundation/hardhat#3639
tablelandnetwork/tableland-js#41

From SyncLinear.com | EVM-15

@sanderpick sanderpick added Improvement Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync labels Mar 28, 2023
@sanderpick
Copy link
Member Author

cc @joewagner

@awmuncy
Copy link
Contributor

awmuncy commented Apr 12, 2023

Gonna have to bump this to next cycle. Nomic is close to done, it seems, but the issue is still open.

@sanderpick
Copy link
Member Author

@awmuncy can you pull this into its own project? I think that would be easier to deal with… we can then close the giant tooling table stakes project.

@awmuncy
Copy link
Contributor

awmuncy commented Apr 21, 2023

Yep, tickets related to the Ethers v6 upgrade have been moved into their own project. And with that, the tooling table stakes project is complete.

@joewagner
Copy link
Contributor

Just looked at this again. Hardhat has setup some beta support for v6, but open zeppelin has conflicting peer deps if we try to upgrade.
Looks like OZ has a dependency bot that created a PR, but it will need someone to manually upgrade.
OpenZeppelin/openzeppelin-upgrades#736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

3 participants