Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVM-15] Upgrade to ethers v6 #337

Closed
joewagner opened this issue Mar 9, 2023 · 3 comments
Closed

[REVM-15] Upgrade to ethers v6 #337

joewagner opened this issue Mar 9, 2023 · 3 comments
Assignees

Comments

@joewagner
Copy link
Contributor

joewagner commented Mar 9, 2023

Now that Ethers v6 has been released we should start to work towards using it here so that the SDK can upgrade to v6.
There will be some complexity in upgrading. This package has ethers as a dev dependency, and some of the other dev dependencies mark ethers as a peer dependency. Those peer dependencies all currently have ethers v5 tagged. Looking at the github repos for these packages makes it seem like they are all going to have versions that use v6 coming out soon.
We should be ready for all those upgrades here.

related:
NomicFoundation/hardhat#3639
tablelandnetwork/tableland-js#41

REVM-15

@joewagner joewagner self-assigned this Mar 9, 2023
@sanderpick sanderpick added linear Sync issue with linear and removed linear Sync issue with linear labels Mar 17, 2023
@sanderpick sanderpick changed the title Upgrade to ethers v6 [REVM-15] Upgrade to ethers v6 Mar 18, 2023
@sanderpick sanderpick added Improvement Created by Linear-GitHub Sync and removed linear Sync issue with linear Improvement Created by Linear-GitHub Sync labels Mar 18, 2023
@joewagner
Copy link
Contributor Author

@sanderpick Looks like you closed this last week. This work is blocking some other issues that are still open. Are we going to deprioritize upgrading ethers?

@sanderpick
Copy link
Member

oop, the issue is over in Linear now. I had synced / unsynced this repo multiple times when testing the sync tool. so ended up just unsyncing issues. we could add the public tag on linear side if we wanted to make a new issue show up here.

@joewagner
Copy link
Contributor Author

oop, the issue is over in Linear now. I had synced / unsynced this repo multiple times when testing the sync tool. so ended up just unsyncing issues. we could add the public tag on linear side if we wanted to make a new issue show up here.

That makes sense. I think it would be good to have this as public since this is blocked by a public PR in hardhat and it's nice for folks to be able to see all of that in github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants