From 717f4b04b69f475ff7dd7ab08b73ceee7cb95849 Mon Sep 17 00:00:00 2001 From: Adam Fowler Date: Tue, 14 May 2024 14:15:43 +0100 Subject: [PATCH] Fix GH action, and fixup benchmark names --- .github/workflows/benchmarks.yaml | 4 ++-- Benchmarks/Benchmarks/BaseN/BaseN.swift | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/benchmarks.yaml b/.github/workflows/benchmarks.yaml index 7fc0741..3a6e7b0 100644 --- a/.github/workflows/benchmarks.yaml +++ b/.github/workflows/benchmarks.yaml @@ -46,7 +46,7 @@ jobs: if: ${{ env.hasBenchmark == '1' }} run: | cd Benchmarks - swift package --allow-writing-to-directory .benchmarkBaselines/ benchmark baseline update pull_request --filter "^(?\!Foundation).*" + swift package --allow-writing-to-directory .benchmarkBaselines/ benchmark baseline update pull_request --filter "^(?!Foundation).*" - name: Switch to branch 'main' if: ${{ env.hasBenchmark == '1' }} run: | @@ -56,7 +56,7 @@ jobs: if: ${{ env.hasBenchmark == '1' }} run: | cd Benchmarks - swift package --allow-writing-to-directory .benchmarkBaselines/ benchmark baseline update main --filter "^(?\!Foundation).*" + swift package --allow-writing-to-directory .benchmarkBaselines/ benchmark baseline update main --filter "^(?!Foundation).*" - name: Compare PR and main if: ${{ env.hasBenchmark == '1' }} id: benchmark diff --git a/Benchmarks/Benchmarks/BaseN/BaseN.swift b/Benchmarks/Benchmarks/BaseN/BaseN.swift index 121e3a6..26cc146 100644 --- a/Benchmarks/Benchmarks/BaseN/BaseN.swift +++ b/Benchmarks/Benchmarks/BaseN/BaseN.swift @@ -84,7 +84,7 @@ let benchmarks = { benchmark.startMeasurement() for _ in benchmark.scaledIterations { - blackHole(Data(base64Encoded: base64, options: .ignoreUnknownCharacters)) + blackHole(Data(base64Encoded: base64)) } } @@ -95,7 +95,7 @@ let benchmarks = { benchmark.startMeasurement() for _ in benchmark.scaledIterations { - blackHole(Data(base64Encoded: base64)) + blackHole(Data(base64Encoded: base64, options: .ignoreUnknownCharacters)) } } }