Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATOP alliances in 2019/20 #9

Closed
joshuaalley opened this issue Sep 6, 2021 · 3 comments
Closed

ATOP alliances in 2019/20 #9

joshuaalley opened this issue Sep 6, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@joshuaalley
Copy link

Thanks for this really useful tool. I'm flagging a small issue with the ATOP alliances data, which has all zeros in dyad-year data for 2019 and 2020.

Here's a simple example:
alliance.min <- create_dyadyears(system = "cow", mry = TRUE, directed = FALSE) %>% add_atop_alliance()
Tabulating the number of dyads with a defense pact returns all 0s for defensive alliances in 2019 or 2020.
table(alliance.min[alliance.min$year >= 2019, ]$atop_defense)

I think these should be NA, as ATOP 5.0 stops at the end of 2018.

@svmiller
Copy link
Owner

svmiller commented Sep 6, 2021

Shit. Thank you for bringing that to my attention. I'll fix that now.

@svmiller svmiller added the bug Something isn't working label Sep 6, 2021
@svmiller
Copy link
Owner

svmiller commented Sep 6, 2021

Fortunately this was an easy fix, but one necessitated by a lazy (on my end) use of an if-else. 535ea4a

@joshuaalley
Copy link
Author

Glad it was an easy fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants