Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_cow_majors() for state-year obs after 2016 #17

Open
rochelleterman opened this issue Aug 28, 2024 · 1 comment
Open

add_cow_majors() for state-year obs after 2016 #17

rochelleterman opened this issue Aug 28, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@rochelleterman
Copy link

Hi,

Thanks for the great package. I noticed a big when trying to apply add_cow_majors() for state-year obs after 2016. For all states 2017 and above, cowmaj is assigned 1.

create_stateyears(system = "cow", mry = TRUE, subset_years = c(1900:2019)) %>%
  add_cow_majors()

I would assume the proper behavior would be to carry over 2016 values or else assign NA to all obs > 2016.

@svmiller svmiller added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 3, 2024
@svmiller
Copy link
Owner

svmiller commented Sep 3, 2024

This is a good thing to note. Given the nature of the data, I don't think it's problematic. But, it's good to note and to give the user the option of honoring the temporal domain of the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants