Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated function darken being used, causing warning #633

Open
uditjainstjis opened this issue Jan 9, 2025 · 2 comments · May be fixed by #634
Open

Deprecated function darken being used, causing warning #633

uditjainstjis opened this issue Jan 9, 2025 · 2 comments · May be fixed by #634

Comments

@uditjainstjis
Copy link

### Description
**1.**In https://github.com/sugarlabs/www/blob/master/css/ion_icon_customization.scss file a depreciated function darken is being used multiple times which is leading to flood of warning's in terminal, it should be replaced by some non-depreciated function as using depreciated function is not a good practice.
**2.**Additionally there is one more issue that bracket '{' missing in the code leading to error which IDE is reflecting

Screenshot 2025-01-09 at 2 37 11 AM
@quozl
Copy link
Contributor

quozl commented Jan 9, 2025

Please don't create issues that you are immediately going to make a pull request for; just create the pull request. Otherwise you hinder our project with unnecessary notifications. Especially as the change is unlikely to be contentious.

Reference: https://github.com/sugarlabs/sugar-docs/blob/master/src/contributing.md#open-an-issue "An issue may be avoided for fixing bugs that are obvious to everyone or part of a project."

@uditjainstjis
Copy link
Author

Oh, I will remember the same to not to raise issues for for fixing bugs or obvious things and will also go through reference page again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants