Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_onResize method called before stage initialization #4300

Closed
4 tasks done
BeNikk opened this issue Jan 22, 2025 · 0 comments · Fixed by #4301
Closed
4 tasks done

_onResize method called before stage initialization #4300

BeNikk opened this issue Jan 22, 2025 · 0 comments · Fixed by #4301

Comments

@BeNikk
Copy link
Contributor

BeNikk commented Jan 22, 2025

Description

The _onResize method in activity.js is being called before this.stage is properly initialized, which could lead to potential errors during the application startup. This occurs during the initial loading phase of Music Blocks.

Expected Behavior

The _onResize method should only execute its resize operations after this.stage has been properly initialized. Currently, we've added a defensive check, but the root cause of the early resize call should be investigated.

Screenshots

Image

How to Reproduce

  1. Load Music Blocks in browser
  2. Open browser developer tools
  3. Observe that _onResize is called during initialization
  4. Check the timing of this.stage initialization versus the first resize call

Environment:

  • Operating System: All (This is a core initialization issue)
  • Browser: All modern browsers
  • Version of Software/Project: Current main branch

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant