Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination on lessons pages is not consistent. #67

Open
kimwhite opened this issue Mar 28, 2024 · 2 comments · May be fixed by #69
Open

Pagination on lessons pages is not consistent. #67

kimwhite opened this issue Mar 28, 2024 · 2 comments · May be fixed by #69

Comments

@kimwhite
Copy link

Describe the bug
If Lessons are created "out of order" or rearranged, pagination does not appear to recognize the change.
The lessons display correctly on the course page, but the pagination at the bottom of the lesson is off or stops working.

To Reproduce
Steps to reproduce the behavior:

  1. Create Course
  2. Create Lessons
  3. Attach Lessons to the course, but not in the order they were created
  4. Go to a Lesson and follow Pagination Links.

Screenshots
https://capture.dropbox.com/IMVGtBBJbTp0FST2

Expected behavior
Pagination should match the Lesson order as set up on the Course Page.

Isolating the problem (mark completed items with an [x]):

  • [ x] I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
  • [ x] This bug happens with a default WordPress theme active, or Memberlite.
  • [ x] I can reproduce this bug consistently using the steps above.

WordPress Environment
WordPress 6.4.3
PMPro 3.0.1
Courses for Membership Add On - 1.2.5
@kimwhite kimwhite changed the title Pagination on Lessons is not constant. Pagination on lessons pages is not consistent. Mar 28, 2024
@MaximilianoRicoTabo MaximilianoRicoTabo linked a pull request Jun 5, 2024 that will close this issue
Open
5 tasks
@thesheryar
Copy link

I recently opened a WordPress thread as well. The workaround for me was to change the order of dates. I think the sorting of the pagination relies on the date.

https://wordpress.org/support/topic/bug-with-sorting-options-in-pmp-courses-w-memberlite-theme/

Let's say we have course "Dogs Training" with 3 lessons.

Lesson 1 date: 1 Jan, 2000 - 1:00 pm
Lesson 2 date: 2 Jan, 2000 - 1:00 pm
Lesson 3 date: 3 Jan, 2000 - 1:00 pm

If the dates are in proper order, the pagination would work just fine, but if the dates are something like this:

Lesson 1 date: 3 Jan, 2000 - 1:00 pm
Lesson 2 date: 4 Jan, 2000 - 1:00 pm
Lesson 3 date: 1 Jan, 2000 - 1:00 pm

It would messed up the pagination.

@kimcoleman
Copy link
Member

We'll work on a fix in Memberlite for this to respect the course's lesson order.

For now, the best path is to unhook the Memberlite post navigation on a single lesson then hook in a function like:

https://gist.github.com/kimcoleman/b9b5271fdf0bed78c4f641d636ef76e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pagination on lessons pages is not consistent. MaximilianoRicoTabo/pmpro-courses
3 participants
@kimcoleman @kimwhite @thesheryar