Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow maximum payload size to be configurable #29

Closed
kylecarbs opened this issue Apr 24, 2022 · 8 comments
Closed

Allow maximum payload size to be configurable #29

kylecarbs opened this issue Apr 24, 2022 · 8 comments

Comments

@kylecarbs
Copy link
Contributor

drpc/drpcwire/reader.go

Line 119 in 41e8fa5

case len(pkt.Data) > 4<<20:

It appears the maximum payload size is 4MB right now and isn't configurable. Is this an intentional design choice?
@vtolstov
Copy link

i think that this must be configured some option.

@zeebo
Copy link
Collaborator

zeebo commented Apr 24, 2022

I think it's fine to expose some options for this. The drpcmanager creates this type and already has an options struct exposed, so adding a NewReaderOptions seems reasonable.

@zeebo
Copy link
Collaborator

zeebo commented Apr 24, 2022

I'll try to do this monday, but I'm also happy to review any PRs :)

@kylecarbs
Copy link
Contributor Author

Awesome- I'll toss one up, was just waiting for confirmation that it wasn't an intentional design choice to avoid!

@kylecarbs kylecarbs mentioned this issue Apr 24, 2022
Merged
@kylecarbs
Copy link
Contributor Author

PR has been linked!

@kylecarbs
Copy link
Contributor Author

#31

This is somewhat related. This error being hidden made it harder to debug.

@zeebo
Copy link
Collaborator

zeebo commented Jun 28, 2022

This is now implemented. Check out https://pkg.go.dev/storj.io/[email protected]/drpcwire#ReaderOptions.

@zeebo zeebo closed this as completed Jun 28, 2022
@kylecarbs
Copy link
Contributor Author

Neato. Thank you @zeebo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zeebo @vtolstov @kylecarbs