From c36635361862bcfb2810fcaa09eec2f9f5b2acde Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Sun, 24 Apr 2022 13:54:30 -0500 Subject: [PATCH] drpcmanager: cancel stream with error when terminated Terminations were canceling streams with `context.Canceled` instead of surfacing the error, causing unexpected behavior. --- drpcmanager/manager.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drpcmanager/manager.go b/drpcmanager/manager.go index 5723abe..9eb3812 100644 --- a/drpcmanager/manager.go +++ b/drpcmanager/manager.go @@ -291,7 +291,8 @@ func (m *Manager) manageStream(ctx context.Context, stream *drpcstream.Stream) { select { case <-m.sigs.term.Signal(): - stream.Cancel(context.Canceled) + err, _ := m.sigs.term.Get() + stream.Cancel(err) <-m.sterm return